-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle exceptions thrown on reflection based calls #28361
Handle exceptions thrown on reflection based calls #28361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An integration test would be in order, as mentioned in the discussion. We have tests with custom plugins in DeclarativeDslProjectBuildFileIntegrationSpec
which might be an example (or something you might want to improve as well if you have better test fixtures for plugins).
...rc/main/kotlin/org/gradle/internal/declarativedsl/mappingToJvm/DeclarativeRuntimeFunction.kt
Show resolved
Hide resolved
be61612
to
c1f4f06
Compare
@bot-gradle test this |
I've triggered the following builds for you. Click here to see all build failures. |
@bot-gradle test and merge |
The merge queue build has started. Click here to see all failures if any. |
Fixes #https://github.com/gradle/gradle-private/issues/4114
Context
Contributor Checklist
<subproject>/src/integTest
) to verify changes from a user perspective.<subproject>/src/test
) to verify logic../gradlew sanityCheck
../gradlew <changed-subproject>:quickTest
.Reviewing cheatsheet
Before merging the PR, comments starting with